Update loadable refs to read_group refs #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrusch
requested changes
Mar 7, 2023
Comment on lines
121
to
125
| query = """select rg.read_group_id, rg.pu | ||
| from read_group rg inner join sample_target_project_view stpv | ||
| on rg.sample_target_id = stpv.sample_target_id and rg.project_id = stpv.project_id | ||
| where status = 'Normal' and formal_name = %s and target_name = %s | ||
| and project_name = %s and subproject = %s;""" |
There was a problem hiding this comment.
Let's take the opportunity to format this (i.e. newlines, indentation, etc.). It's already changed enough that the whole block is a diff, so no reason not to fix the lack of formatting of the query.
There was a problem hiding this comment.
Something like this?
query = """select
rg.read_group_id,
rg.pu
from
read_group rg
inner join sample_target_project_view stpv
on rg.sample_target_id = stpv.sample_target_id and rg.project_id = stpv.project_id
where
status = 'Normal'
and formal_name = %s
and target_name = %s
and project_name = %s
and subproject = %s;"""
darosenfeld
approved these changes
Aug 9, 2024
mcrusch
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.